Added sanya.markdown #2056
Merged
Added sanya.markdown #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SanyaMehra <[email protected]>
SanyaMehra
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws and
nateynateynate
as code owners
ashwin-pc
reviewed
Sep 21, 2023
There was a problem hiding this comment.
@SanyaMehra can you move the file to _authors/osci_2023 folder? Sorry there was a mistake in my instructions. Apologies for that.
_authors/sanya.markdown
Outdated
| --- | ||
| name: Sanya Mehra | ||
| short_name: Sanya | ||
| twitter: <twitter handle without the @> |
Signed-off-by: SanyaMehra <[email protected]>
|
Hello Ashwin,
The markdown file should be in the correct folder now, but I am not sure
which line from the file you are specifying to remove. I am also not sure
if I correctly completed all the steps because when I compare changes in
GitHub, I am unable to select my own branch in the last compare dropdown
and therefore unable to click the green create pull request button. Let me
know if I am missing something.
Thanks,
Sanya
…On Thu, Sep 21, 2023 at 6:25 PM Ashwin P Chandran ***@***.***> wrote:
***@***.**** commented on this pull request.
@SanyaMehra <https://github.com/SanyaMehra> can you move the file to
_authors/osci_2023 folder? Sorry there was a mistake in my instructions.
Apologies for that.
------------------------------
In _authors/sanya.markdown
<#2056 (comment)>
:
> @@ -0,0 +1,8 @@
+---
+name: Sanya Mehra
+short_name: Sanya
+twitter: <twitter handle without the @>
Can you remove this line?
—
Reply to this email directly, view it on GitHub
<#2056 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANXG3WUXZ56SE6IODIVJOF3X3S5FVANCNFSM6AAAAAA5B3YXVI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Signed-off-by: SanyaMehra <[email protected]>
Signed-off-by: David Tippett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sanya.markdown in _authors folder
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.