Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSCI]: add author skollryu md #2068

Merged
merged 2 commits into from
Sep 25, 2023
Merged

[OSCI]: add author skollryu md #2068

merged 2 commits into from
Sep 25, 2023

Conversation

SkollRyu
Copy link
Contributor

Description

Add a markdown page for myself

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@SkollRyu SkollRyu changed the title feat: add author skollryu md [OSCI]: add author skollryu md Sep 21, 2023
ashwin-pc
ashwin-pc suggested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SkollRyu can you move this file to _authors/osci_2023? Sorry there was an error in my notes.

@SkollRyu
Copy link
Contributor Author

@ashwin-pc resolved. Please Check. Thanks

joshuarrrr
joshuarrrr approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtaivpp
dtaivpp approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@dtaivpp dtaivpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@dtaivpp dtaivpp merged commit 668e959 into opensearch-project:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc requested changes

@dtaivpp dtaivpp dtaivpp approved these changes

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@elfisher elfisher Awaiting requested review from elfisher elfisher is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@krisfreedain krisfreedain Awaiting requested review from krisfreedain krisfreedain is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@nateynateynate nateynateynate Awaiting requested review from nateynateynate nateynateynate is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SkollRyu @joshuarrrr @dtaivpp @ashwin-pc