[OSCI] Adds new author VJoshi380 #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vedang Joshi <[email protected]>
Signed-off-by: Vedang Joshi <[email protected]>
VJoshi380
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws and
nateynateynate
as code owners
joshuarrrr
suggested changes
Sep 25, 2023
| github: VJoshi380 | ||
| --- | ||
|
|
||
| **Vedang Joshi** I love security through obsucrity :O |
There was a problem hiding this comment.
I'm not sure if the spelling is the joke, but if not:
Suggested change
| **Vedang Joshi** I love security through obsucrity :O | |
| **Vedang Joshi** I love security through obscurity :O |
Comment on lines
3
to
4
| short_name: | ||
| twitter: |
There was a problem hiding this comment.
remove these if not needed
Suggested change
| short_name: | |
| twitter: |
|
@VJoshi380 once you address Josh's comments we are good to go, thank you! |
Signed-off-by: Vedang Joshi <[email protected]>
|
Thanks for letting me know about the issues. I've removed the unused sections and fixed the typo. Let me know if any other fixes need to be made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Placing Vedang Joshi in the authors section of the website repository.
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.