Bootstrap integrate into entire website #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
head.html is called by the default template. Doing this effectively integrates bootstrap to our entire site. In styles.scss, I removed the manually styling for container elements, bootstrap will now take over the rendering, and resizing of these elements. Signed-off-by: kaimmej <[email protected]>
…lt.html template, instead of the custom one i created. Deleted - head-blog.html and head-default.html both of these are now redundent. They were being used to bring bootstrap into these pages. Now that bootstrap is integrated into our site, we can switch these back to the default template. Blog had a few issues with the new bootstrap styling - I believe this was caused by the ordering of the stylesheets in head.html. Because bootstrap is being included before our custom .scss files, bootstrap no longer takes precedence. I changed the blog titles to be <h2> tags instead of <h3> to make them more readable. I changed the padding of the partners page so that bootstrap is taking over the padding structure of the cards. Additionally - I added the year that the blog post was released. Signed-off-by: kaimmej <[email protected]>
kaimmej
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws,
nateynateynate and
natebower
as code owners
nateynateynate
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change brings bootstrap into the default head of every page. Effectively, it turns over the rendering of all of our elements to bootstrap.
Part of this change included reorganizaing the padding of both the blog/index.html and partners/index.html pages. This was to turn off the manual padding that we had been doing through the _partners.scss styling (note - this padding was the reason for the featured blog posts image not stretching to the edge of its card).
Additionally, I removed the previous templates I had created where I was including bootstrap into the blog and partners pages I redesigned. I deleted the new templates I made, and switched them over to the default template.
also - I am included the year of the blog post in the card. This closes issue #3044
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.