Fix table strings and add unit tests #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansjcy
changed the title
ansjcy
force-pushed
the
unit-tests-for-QID
branch
from
2dfcb84 to
40b5746
Compare
|
Let's rebase this change to fix the build error on cypress version: #34 |
ansjcy
force-pushed
the
unit-tests-for-QID
branch
2 times, most recently
from
82c6749 to
aeef0aa
Compare
Signed-off-by: Chenyang Ji <[email protected]>
ansjcy
force-pushed
the
unit-tests-for-QID
branch
2 times, most recently
from
f6e3191 to
df66313
Compare
Signed-off-by: Chenyang Ji <[email protected]>
ansjcy
force-pushed
the
unit-tests-for-QID
branch
3 times, most recently
from
7572e04 to
803e180
Compare
Signed-off-by: Chenyang Ji <[email protected]>
ansjcy
force-pushed
the
unit-tests-for-QID
branch
from
803e180 to
38c8932
Compare
dzane17
approved these changes
Jan 14, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Fix table strings and add unit tests Signed-off-by: Chenyang Ji <[email protected]> * update snapshots Signed-off-by: Chenyang Ji <[email protected]> * fix date string Signed-off-by: Chenyang Ji <[email protected]> --------- Signed-off-by: Chenyang Ji <[email protected]> (cherry picked from commit c2519b8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Fix table strings and add unit tests * update snapshots * fix date string --------- (cherry picked from commit c2519b8) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix anti-pattern table strings and add extensive unit tests for the configuration and overview page.
Issues Resolved
Related: #16
Related PR: https://github.com/opensearch-project/query-insights-dashboards/pull/21/files
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.