Query/group details make API call to fetch data #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhant Deshmukh <[email protected]>
deshsidd
force-pushed
the
sid/query-id-ui
branch
from
d04dd05 to
c3760a4
Compare
ansjcy
reviewed
Jan 23, 2025
public/pages/QueryGroupDetails/Components/QueryGroupAggregateSummary.tsx
Show resolved
Hide resolved
Thanks for the review! Added the screenshots to the description. |
ansjcy
approved these changes
Jan 23, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit 3577141) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd
pushed a commit
that referenced
this pull request
Jan 23, 2025
(cherry picked from commit 3577141) Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that the url for the query/group details page now contains
to,fromandid. The query/group details page should make an API call to the backend to fetch the details to populate on the page. Previously we were passing this information from the parent page.UI changes corresponding to the following backend changes : opensearch-project/query-insights#195
Change details:
to,fromandidas url params for the query/group details pageIssues Resolved
closes: #42
closes: #12
Testing:
Tested on local.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.