Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QI-Styling-Configuration #85

Conversation

KishoreKicha14
Copy link

@KishoreKicha14 KishoreKicha14 commented Jan 29, 2025

Screenshot 2025-01-29 at 1 02 37 PM Screenshot 2025-01-29 at 3 09 37 PM

Description

This change introduces improvements to the configuration page by enhancing the UI and aligning it with the latest design guidelines. The main updates include:

  • Ensuring the use of semantic header tags for accessibility.
  • Adjusting text sizes for regular and heading text to match the type ramp specifications.
  • Implementing consistent padding and layout for a clean and responsive design.
  • Using EuiFlexGroup, EuiPanel, and other components to structure the content in a modular, maintainable manner.

Changed Made

EuiDescriptionList Integration:

  • Used to display configuration settings with their descriptions.
  • Helps maintain a clear and concise UI.
  • Configurations like "Enabled" and their respective descriptions (e.g., "Enable/disable top N query monitoring") are displayed in a compact and organized manner.
    Compressed Layout:
  • Utilized the compressed={true} prop to minimize the vertical space between items, ensuring the UI stays compact and avoids unnecessary scrolling.
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
@deshsidd
Copy link
Collaborator

Looks like cypress tests are failing on the query group details page. Please take a look @KishoreKicha14

@ansjcy
Copy link
Member

ansjcy commented Jan 30, 2025

Please iterate from the previous PR instead of creating new ones: #68

@ansjcy ansjcy closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants