-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] fix chained findings monitor logic in update detector flow #1020
Conversation
* fix chained findings monitor logic in update detector flow Signed-off-by: Surya Sashank Nistala <[email protected]> * extract check for chained findings monitor into a re-usable method. create constant for chained findings monitor string literal Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit df5f746) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1020 +/- ##
============================================
- Coverage 24.76% 24.75% -0.01%
- Complexity 1053 1054 +1
============================================
Files 280 280
Lines 12899 12907 +8
Branches 1407 1410 +3
============================================
+ Hits 3194 3195 +1
- Misses 9431 9439 +8
+ Partials 274 273 -1 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.11 2.11
# Navigate to the new working tree
cd .worktrees/backport-2.11
# Create a new branch
git switch --create backport/backport-1020-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c162a6f300b7cf4afee0513159650da2fdf5bb9b
# Push it to GitHub
git push --set-upstream origin backport/backport-1020-to-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.11 Then, create a pull request where the |
…1020) * fix chained findings monitor logic in update detector flow * extract check for chained findings monitor into a re-usable method. create constant for chained findings monitor string literal --------- (cherry picked from commit df5f746) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit c162a6f)
…1020) * fix chained findings monitor logic in update detector flow * extract check for chained findings monitor into a re-usable method. create constant for chained findings monitor string literal --------- (cherry picked from commit df5f746) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit c162a6f)
…1020) (#1023) * fix chained findings monitor logic in update detector flow * extract check for chained findings monitor into a re-usable method. create constant for chained findings monitor string literal --------- (cherry picked from commit df5f746) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit c162a6f) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Backport df5f746 from #1019.