Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.15] adds new tif source config type - url download #1155

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 16bcef3 from #1142.

* adds new tif source config type - url download

Signed-off-by: Surya Sashank Nistala <[email protected]>

* set up create default tif configs

Signed-off-by: Surya Sashank Nistala <[email protected]>

* address review comments

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add check to block create and delete operation url download type tif source configs

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 16bcef3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 51.82482% with 132 lines in your changes missing coverage. Please review.

Project coverage is 67.51%. Comparing base (57f3181) to head (3461c5b).

Files Patch % Lines
...el/service/SATIFSourceConfigManagementService.java 6.45% 29 Missing ⚠️
...l/service/DefaultTifSourceConfigLoaderService.java 65.38% 22 Missing and 5 partials ⚠️
...ansport/TransportSearchTIFSourceConfigsAction.java 3.70% 26 Missing ⚠️
...analytics/threatIntel/model/UrlDownloadSource.java 69.23% 14 Missing and 2 partials ⚠️
...curityanalytics/services/STIX2IOCFetchService.java 68.75% 10 Missing and 5 partials ⚠️
...s/threatIntel/common/SourceConfigDtoValidator.java 0.00% 4 Missing ⚠️
...transport/TransportIndexTIFSourceConfigAction.java 0.00% 3 Missing and 1 partial ⚠️
...lytics/threatIntel/util/ThreatIntelFeedParser.java 55.55% 4 Missing ⚠️
...tyanalytics/transport/TransportListIOCsAction.java 72.72% 3 Missing ⚠️
...hreatIntel/service/ThreatIntelFeedDataService.java 0.00% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##               2.15    #1155      +/-   ##
============================================
+ Coverage     67.31%   67.51%   +0.19%     
- Complexity     3405     3457      +52     
============================================
  Files           402      404       +2     
  Lines         19455    19715     +260     
  Branches       1984     2008      +24     
============================================
+ Hits          13097    13311     +214     
- Misses         5399     5440      +41     
- Partials        959      964       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eirsep eirsep merged commit 8b28f2c into 2.15 Jul 10, 2024
21 of 33 checks passed
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Jul 10, 2024
…) (opensearch-project#1155)

* adds new tif source config type - url download



* set up create default tif configs



* address review comments



* add check to block create and delete operation url download type tif source configs



---------


(cherry picked from commit 16bcef3)

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Jul 10, 2024
…) (opensearch-project#1155)

* adds new tif source config type - url download

* set up create default tif configs

* address review comments

* add check to block create and delete operation url download type tif source configs

---------

(cherry picked from commit 16bcef3)

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants