Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.15] Fix the job scheduler parser, action listeners, and multi-node test #1161

Merged
merged 1 commit into from
Jul 12, 2024
Merged

[Backport 2.15] Fix the job scheduler parser, action listeners, and multi-node test #1161

merged 1 commit into from
Jul 12, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b8496a9 from #1157.

@github-actions
Fix the job scheduler parser, action listeners, and multi-node test (#…
70b0f27 
…1157)

* fix job parser

Signed-off-by: Joanne Wang <[email protected]>

* fix listener.onFailure

Signed-off-by: Joanne Wang <[email protected]>

* fix flaky create threat intel monitor test

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit b8496a9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 71.15385% with 15 lines in your changes missing coverage. Please review.

Project coverage is 67.48%. Comparing base (95d0099) to head (70b0f27).

Files Patch % Lines
...tyanalytics/threatIntel/model/TIFJobParameter.java 80.95% 5 Missing and 3 partials ⚠️
...rch/securityanalytics/SecurityAnalyticsPlugin.java 42.85% 3 Missing and 1 partial ⚠️
...nalytics/jobscheduler/SecurityAnalyticsRunner.java 0.00% 2 Missing ⚠️
...threatIntel/iocscan/dao/BaseEntityCrudService.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.15    #1161      +/-   ##
============================================
+ Coverage     67.37%   67.48%   +0.10%     
- Complexity     3456     3469      +13     
============================================
  Files           404      404              
  Lines         19715    19757      +42     
  Branches       2008     2015       +7     
============================================
+ Hits          13283    13333      +50     
+ Misses         5472     5454      -18     
- Partials        960      970      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowg-amazon jowg-amazon merged commit 7b9a329 into 2.15 Jul 12, 2024
27 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jowg-amazon jowg-amazon jowg-amazon approved these changes

@eirsep eirsep eirsep approved these changes

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@AWSHurneyt AWSHurneyt Awaiting requested review from AWSHurneyt AWSHurneyt is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@goyamegh goyamegh Awaiting requested review from goyamegh goyamegh is a code owner

@riysaxen-amzn riysaxen-amzn Awaiting requested review from riysaxen-amzn riysaxen-amzn is a code owner

Assignees
No one assigned
Labels
autocut
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eirsep @jowg-amazon