[Backport 2.17] threat intel monitor bug fixes #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* handle exception arising from trying to search with sort on empty index Signed-off-by: Surya Sashank Nistala <[email protected]> * add setting to test max term count in threat intel ioc scan terms query and verify grouped listener wiring Signed-off-by: Surya Sashank Nistala <[email protected]> * remove unused variable Signed-off-by: Surya Sashank Nistala <[email protected]> * avoid grouped listener being initiated with size 0 Signed-off-by: Surya Sashank Nistala <[email protected]> * add verification that empty index scan is handled gracefully Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 39c29d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.17 #1322 +/- ##
============================================
+ Coverage 68.59% 68.75% +0.15%
- Complexity 3575 3583 +8
============================================
Files 404 404
Lines 20019 20038 +19
Branches 2041 2042 +1
============================================
+ Hits 13733 13777 +44
+ Misses 5269 5240 -29
- Partials 1017 1021 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eirsep
approved these changes
Sep 25, 2024
amsiglan
approved these changes
Sep 25, 2024
|
ci failure is in upload artifacts step after tests passed. infra issue not code blocker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 39c29d4 from #1317.