Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.16] [Bug] Add exists check for IOCs index. #1396

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[Backport 2.16] [Bug] Add exists check for IOCs index. #1396

merged 1 commit into from
Oct 28, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4432b36 from #1392.

@github-actions
[Bug] Add exists check for IOCs index. (#1392)
bfc5c83 
* Added check to prevent resource_already_exists_exception when indexing more than 10k iocs.

Signed-off-by: AWSHurneyt <[email protected]>

* Changed log message.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 4432b36)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.66%. Comparing base (2b7d37d) to head (bfc5c83).
Report is 1 commits behind head on 2.16.

Files with missing lines Patch % Lines
.../securityanalytics/services/STIX2IOCFeedStore.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.16    #1396      +/-   ##
============================================
- Coverage     68.67%   68.66%   -0.01%     
  Complexity     3575     3575              
============================================
  Files           404      404              
  Lines         20017    20021       +4     
  Branches       2041     2041              
============================================
+ Hits          13746    13748       +2     
- Misses         5252     5253       +1     
- Partials       1019     1020       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AWSHurneyt AWSHurneyt merged commit 4a7d588 into 2.16 Oct 28, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jowg-amazon jowg-amazon jowg-amazon approved these changes

@AWSHurneyt AWSHurneyt AWSHurneyt approved these changes

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@eirsep eirsep Awaiting requested review from eirsep eirsep is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@goyamegh goyamegh Awaiting requested review from goyamegh goyamegh is a code owner

@riysaxen-amzn riysaxen-amzn Awaiting requested review from riysaxen-amzn riysaxen-amzn is a code owner

Assignees
No one assigned
Labels
autocut
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AWSHurneyt @jowg-amazon