Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.15] Add validation for threat intel source config #1406

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[Backport 2.15] Add validation for threat intel source config #1406

merged 1 commit into from
Oct 31, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 364f42d from #1393.

@github-actions
Add validation for threat intel source config (#1393)
9692350 
* add validation for source config and allow null to be read in parser

Signed-off-by: Joanne Wang <[email protected]>

* add parsing tests

Signed-off-by: Joanne Wang <[email protected]>

* add additional validation

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 364f42d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 49.15254% with 30 lines in your changes missing coverage. Please review.

Project coverage is 69.09%. Comparing base (3a5cbe7) to head (9692350).
Report is 1 commits behind head on 2.15.

Files with missing lines Patch % Lines
...s/threatIntel/common/SourceConfigDtoValidator.java 29.72% 11 Missing and 15 partials ⚠️
...analytics/threatIntel/model/SATIFSourceConfig.java 81.81% 1 Missing and 1 partial ⚠️
...lytics/threatIntel/model/SATIFSourceConfigDto.java 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.15    #1406      +/-   ##
============================================
+ Coverage     69.00%   69.09%   +0.09%     
- Complexity     3602     3617      +15     
============================================
  Files           404      404              
  Lines         20072    20103      +31     
  Branches       2046     2060      +14     
============================================
+ Hits          13851    13891      +40     
+ Misses         5194     5182      -12     
- Partials       1027     1030       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AWSHurneyt AWSHurneyt merged commit 791218b into 2.15 Oct 31, 2024
25 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jowg-amazon jowg-amazon jowg-amazon approved these changes

@AWSHurneyt AWSHurneyt AWSHurneyt approved these changes

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@eirsep eirsep Awaiting requested review from eirsep eirsep is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@goyamegh goyamegh Awaiting requested review from goyamegh goyamegh is a code owner

@riysaxen-amzn riysaxen-amzn Awaiting requested review from riysaxen-amzn riysaxen-amzn is a code owner

Assignees
No one assigned
Labels
autocut
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AWSHurneyt @jowg-amazon