Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing hard-coded password with randomly generated string #1420

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

toepkerd
Copy link
Contributor

@toepkerd toepkerd commented Nov 29, 2024

Description

Replaces hard-coded password in integration test with randomly generated string for security purposes

Check List

  • [Y] New functionality includes testing.
  • [N/A] New functionality has been documented.
  • [N/A] API changes companion pull request created.
  • [Y] Commits are signed per the DCO using --signoff.
  • [N/A] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@toepkerd
Copy link
Contributor Author

toepkerd commented Dec 2, 2024

Failing CIs fail with error

/__e/node20/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)

Local build and other build/test CIs pass, so this error must be a CI misconfiguration issue.

@AWSHurneyt AWSHurneyt merged commit 6dc86c6 into opensearch-project:main Dec 3, 2024
7 of 9 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.x
# Create a new branch
git switch --create backport-1420-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6dc86c6e30caf72ec4c27f3d32ac21015e0b235f
# Push it to GitHub
git push --set-upstream origin backport-1420-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-1420-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants