fixes the duplicate alerts generated by Aggregation Sigma Roles #1424
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas and
goyamegh
as code owners
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
sbcd90
previously approved these changes
Dec 18, 2024
Signed-off-by: Riya Saxena <[email protected]>
sbcd90
approved these changes
Dec 18, 2024
|
the test is flaky, Security test workflow previously also failed due to the same test failing -> https://github.com/opensearch-project/security-analytics/actions/runs/12291138377/job/34299407796#step:8:305 |
eirsep
approved these changes
Dec 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
* De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * tests fix Signed-off-by: Riya Saxena <[email protected]> * tests fix Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 4845337) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
* De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * tests fix Signed-off-by: Riya Saxena <[email protected]> * tests fix Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 4845337) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
* De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * tests fix Signed-off-by: Riya Saxena <[email protected]> * tests fix Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 4845337) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sbcd90
pushed a commit
that referenced
this pull request
Dec 18, 2024
… (#1435) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
* De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * tests fix Signed-off-by: Riya Saxena <[email protected]> * tests fix Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 4845337) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
* De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * De-dupe Alerts generated by Aggregation Sigma Rules fix Signed-off-by: Riya Saxena <[email protected]> * tests fix Signed-off-by: Riya Saxena <[email protected]> * tests fix Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 4845337) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Detectors configured with aggregation sigma rules should ideally generate only one alert in one execution when a set of documents match the rule’s condition. But currently there are duplicate alerts being generated when aggregate sigma rules are matched.
Root cause
Doc level monitor fans out the work to different nodes and assigns shards to each node and passed the finding_ids and doc_ids to filter and fetch the matching docs.
If the matching docs are present on different shards and the different shards are being queried by different fan-out nodes, each fan-out operation creates it’s own alert. Hence 3 nodes could create the alert for one trigger and user sees duplicates.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.