Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature findings api enhancements #914

Merged
merged 32 commits into from
Mar 13, 2024
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
2ffe265
get all findings as part of findings API enhancement
riysaxen-amzn Jan 16, 2024
705988f
findingsAPI feature enhancements (address comments to prev PR)
riysaxen-amzn Jan 19, 2024
854c44c
findingsAPI feature enhancements (address comments to prev PR)
riysaxen-amzn Jan 19, 2024
8bb1d7e
added support for param in Finding API
riysaxen-amzn Jan 31, 2024
303493c
added detectionType as param for Findings API enhancements
riysaxen-amzn Jan 31, 2024
d6a914e
added few tests to validate findings by params
riysaxen-amzn Feb 14, 2024
d8d4051
Merge branch 'opensearch-project:main' into feature-findingsAPIenhanc…
riysaxen-amzn Feb 14, 2024
0eb7dce
added test for searchString param in FindingsAPI
riysaxen-amzn Feb 24, 2024
6b2a15c
adding addiional params findingIds, startTime and endTime as findings…
riysaxen-amzn Feb 29, 2024
0804c8b
added params in getFindingsByDetectorId func
riysaxen-amzn Mar 5, 2024
b9349c1
changed the startTime and endTime req input format
riysaxen-amzn Mar 6, 2024
5a80380
Merge branch 'main' into feature-findingsAPIenhancements
riysaxen-amzn Mar 9, 2024
13f74db
fix merge conflixt
riysaxen-amzn Mar 9, 2024
02f7000
fix integ test failures in findings API
riysaxen-amzn Mar 11, 2024
8a7c3d8
fix integ tests
riysaxen-amzn Mar 11, 2024
b29cd33
refactored the logic
riysaxen-amzn Mar 13, 2024
7a63ec0
remove unused imports
riysaxen-amzn Mar 13, 2024
ccc84ea
address the pr comments
riysaxen-amzn Mar 13, 2024
dae015b
address pr comments
riysaxen-amzn Mar 13, 2024
b45660b
SA integ tests fix
riysaxen-amzn Mar 13, 2024
5ba7a0f
SA integ tests fix
riysaxen-amzn Mar 13, 2024
a5adf95
Merge branch 'main' into feature-findingsAPIenhancements
riysaxen-amzn Mar 13, 2024
369ca7d
fix integ tests for findings
sbcd90 Mar 11, 2024
c15e577
fix conflixt errors
riysaxen-amzn Mar 13, 2024
02fc845
fix conflixt errors
riysaxen-amzn Mar 13, 2024
de8bf2f
fix conflixt errors
riysaxen-amzn Mar 13, 2024
2587fca
fix conflixt errors
riysaxen-amzn Mar 13, 2024
f3eb85d
fix integ tests
riysaxen-amzn Mar 13, 2024
f20ed7f
fix integ tests
riysaxen-amzn Mar 13, 2024
8fc5960
fix integ tests
riysaxen-amzn Mar 13, 2024
19ff06e
fix flaky integ tests
riysaxen-amzn Mar 13, 2024
d8043ef
address pr comments
riysaxen-amzn Mar 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix conflixt errors
Signed-off-by: Riya Saxena <[email protected]>
  • Loading branch information
riysaxen-amzn committed Mar 13, 2024
commit c15e57728565c9a7d6726e077c89d4c462326513
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ public void getFindingsByMonitorIds(
ActionListener<GetFindingsResponse> listener
) {
BoolQueryBuilder queryBuilder = getBoolQueryBuilder(detectionType, severity, findingIds, startTime, endTime);

org.opensearch.commons.alerting.action.GetFindingsRequest req =
new org.opensearch.commons.alerting.action.GetFindingsRequest(
null,
Expand Down