[Backport 2.x] [BUG] Changes doc level query name field from id to rule name and adds validation #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…s validation (#972) * change doc level query name field to rule name and add validation Signed-off-by: Joanne Wang <[email protected]> * call validation from common utils Signed-off-by: Joanne Wang <[email protected]> * change sigma title validation Signed-off-by: Joanne Wang <[email protected]> * add name to doc level query Signed-off-by: Joanne Wang <[email protected]> * fix unit tests Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit b86ee63)
opensearch-trigger-bot
bot
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
praveensameneni
approved these changes
Apr 13, 2024
(cherry picked from commit 06e370f) Co-authored-by: Subhobrata Dey <[email protected]>
…s validation (#972) * change doc level query name field to rule name and add validation Signed-off-by: Joanne Wang <[email protected]> * call validation from common utils Signed-off-by: Joanne Wang <[email protected]> * change sigma title validation Signed-off-by: Joanne Wang <[email protected]> * add name to doc level query Signed-off-by: Joanne Wang <[email protected]> * fix unit tests Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit b86ee63)
…nsearch-project/security-analytics into backport/backport-972-to-2.x
|
closing in favor of #984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b86ee63 from #972