-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing license header #3467
Add missing license header #3467
Conversation
966694e
to
9f33f37
Compare
|
9f33f37
to
83fdca2
Compare
Codecov Report
@@ Coverage Diff @@
## main #3467 +/- ##
============================================
+ Coverage 64.58% 64.62% +0.03%
- Complexity 3575 3576 +1
============================================
Files 275 275
Lines 20451 20451
Branches 3382 3382
============================================
+ Hits 13208 13216 +8
+ Misses 5546 5538 -8
Partials 1697 1697
|
@willyborankin needs rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willyborankin Can you file an issue to run a license checker as part of the CI?
If I remember correctly, core does this in the precommit.
Yes that's why I found the problem |
Created an issue #3471 |
@reta Hmmm I rebased it still fails. |
Ah ... it is for
|
Signed-off-by: Andrey Pleskach <[email protected]>
83fdca2
to
3d30564
Compare
Finally the pipeline works just fine. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3467-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fb82bbbfcc133fa4ae0bba227c881f7a6ebbe7bd
# Push it to GitHub
git push --set-upstream origin backport/backport-3467-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
Added missing license header for some files. - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Andrey Pleskach <[email protected]> (cherry picked from commit fb82bbb)
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.11
# Create a new branch
git switch --create backport/backport-3467-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fb82bbbfcc133fa4ae0bba227c881f7a6ebbe7bd
# Push it to GitHub
git push --set-upstream origin backport/backport-3467-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.11 Then, create a pull request where the |
Added missing license header for some files. - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Andrey Pleskach <[email protected]> (cherry picked from commit fb82bbb)
Added missing license header for some files. - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Andrey Pleskach <[email protected]> (cherry picked from commit fb82bbb)
Backports #3467 via fb82bbb Manual backport is required to address white space conflicts in relevant files Co-authored-by: Andrey Pleskach <[email protected]>
…t#3467) (opensearch-project#3480)" This reverts commit fed822b.
Description
Added missing license header for some files.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.