Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.apache.zookeeper:zookeeper to 3.9.1 and io.netty:netty-tcnative-boringssl-static to 2.0.61.Final #3532

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Oct 12, 2023

Description

Bump zookeeper to 3.9.1 and io.netty:netty-tcnative-boringssl-static to 2.0.61.Final to resolve whitesource check failure.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

reta
reta previously approved these changes Oct 12, 2023
@cwperks cwperks changed the title Bump org.apache.zookeeper:zookeeper to 3.9.1 Bump org.apache.zookeeper:zookeeper to 3.9.1 and io.netty:netty-tcnative-boringssl-static to 2.0.61.Final Oct 12, 2023
peternied
peternied previously approved these changes Oct 12, 2023
@cwperks cwperks added the backport 2.x backport to 2.x branch label Oct 12, 2023
@cwperks
Copy link
Member Author

cwperks commented Oct 12, 2023

Getting jarHell >.<

Suite: Test class org.opensearch.security.sanity.tests.SingleClusterSanityIT
  2> java.lang.RuntimeException: found jar hell in test classpath
        at org.opensearch.bootstrap.BootstrapForTesting.<clinit>(BootstrapForTesting.java:119)
        at org.opensearch.test.OpenSearchTestCase.<clinit>(OpenSearchTestCase.java:268)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:467)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$2.run(RandomizedRunner.java:623)

        Caused by:
        java.lang.IllegalStateException: jar hell!
        class: org.slf4j.impl.StaticLoggerBinder
        jar1: /home/runner/.gradle/caches/modules-2/files-2.1/ch.qos.logback/logback-classic/1.2.10/f69d97ef3335c6ab82fc21dfb77ac613f90c1221/logback-classic-1.2.10.jar
        jar2: /home/runner/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-slf4j-impl/2.20.0/7ab4f082fd162f60afcaf2b8744a3d959feab3e8/log4j-slf4j-impl-2.20.0.jar
            at org.opensearch.bootstrap.JarHell.checkClass(JarHell.java:316)
            at org.opensearch.bootstrap.JarHell.checkJarHell(JarHell.java:215)
            at org.opensearch.bootstrap.JarHell.checkJarHell(JarHell.java:102)
            at org.opensearch.bootstrap.BootstrapForTesting.<clinit>(BootstrapForTesting.java:117)
            ... 4 more

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #3532 (e1db48c) into main (387c8a5) will decrease coverage by 1.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3532      +/-   ##
============================================
- Coverage     64.96%   63.66%   -1.31%     
+ Complexity     3638     3556      -82     
============================================
  Files           281      281              
  Lines         20581    20581              
  Branches       3398     3398              
============================================
- Hits          13371    13103     -268     
- Misses         5522     5755     +233     
- Partials       1688     1723      +35     

see 35 files with indirect coverage changes

build.gradle Show resolved Hide resolved
@DarshitChanpura DarshitChanpura merged commit 23359f6 into opensearch-project:main Oct 12, 2023
58 of 59 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2023
…ive-boringssl-static to 2.0.61.Final (#3532)

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 23359f6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants