Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure initialAdminPassword is available. #3549

Closed

Conversation

davidosorno
Copy link
Contributor

Description

Ensure initialAdminPassword is setup when running demo configuration.

Issues Resolved

#3508

Testing

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #3549 (a15fbed) into main (6b91e57) will decrease coverage by 36.33%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##               main    #3549       +/-   ##
=============================================
- Coverage     64.98%   28.65%   -36.33%     
+ Complexity     3637     1463     -2174     
=============================================
  Files           281      282        +1     
  Lines         20579    20597       +18     
  Branches       3390     3390               
=============================================
- Hits          13373     5902     -7471     
- Misses         5519    13685     +8166     
+ Partials       1687     1010      -677     

see 205 files with indirect coverage changes

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for this change. The core issue is when running a distribution, say docker for example, this script would exit with 1 however the cluster spin-up will continue which will cause admin user to be created since internal_users.yml was not modified by this script to update the new admin password.

Would you want to take a look at identifying and fixing that? It might involve you looking and fixing things outside security repo. Here are some resources to help you get started in case you are interested:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants