Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix SSL config for JDK PKCS setup #5033

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 48be2af from #4999.

Signed-off-by: Andrey Pleskach <[email protected]>
(cherry picked from commit 48be2af)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@cwperks
Copy link
Member

cwperks commented Jan 16, 2025

Fixing the CI error in #5028

CI Error:

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@cwperks
Copy link
Member

cwperks commented Jan 17, 2025

Sync'ed with 2.x to resolve the CI failures in bwc tests related to outdated GH action for test artifact upload

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.06%. Comparing base (a7d2c57) to head (3618037).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...rch/security/ssl/config/SslCertificatesLoader.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #5033      +/-   ##
==========================================
- Coverage   68.06%   68.06%   -0.01%     
==========================================
  Files         346      346              
  Lines       24503    24504       +1     
  Branches     4061     4062       +1     
==========================================
- Hits        16679    16678       -1     
  Misses       5904     5904              
- Partials     1920     1922       +2     
Files with missing lines Coverage Δ
...rch/security/ssl/config/SslCertificatesLoader.java 87.03% <66.66%> (-1.65%) ⬇️

... and 3 files with indirect coverage changes

@cwperks cwperks merged commit 5969ca9 into 2.x Jan 17, 2025
90 of 91 checks passed
@cwperks cwperks deleted the backport/backport-4999-to-2.x branch January 17, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants