Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change commons-lang3 version #45

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

zhichao-aws
Copy link
Member

Description

fix the version of commons-lang3 to fix the build

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: zhichao-aws <[email protected]>
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (6ec9b0c) 38.65% compared to head (8546bc4) 44.41%.
Report is 15 commits behind head on main.

Files Patch % Lines
...search/agent/tools/SearchAnomalyDetectorsTool.java 65.78% 11 Missing and 15 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #45      +/-   ##
============================================
+ Coverage     38.65%   44.41%   +5.76%     
- Complexity       24       30       +6     
============================================
  Files             5        6       +1     
  Lines           282      358      +76     
  Branches         24       42      +18     
============================================
+ Hits            109      159      +50     
- Misses          167      178      +11     
- Partials          6       21      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhichao-aws zhichao-aws merged commit cd1cfc4 into opensearch-project:main Dec 22, 2023
12 of 13 checks passed
zhichao-aws added a commit to zhichao-aws/skills that referenced this pull request Dec 25, 2023
zane-neo pushed a commit that referenced this pull request Dec 25, 2023
zhichao-aws added a commit that referenced this pull request Dec 25, 2023
…lSparseTools (#58)

* Merge pull request #40 from zhichao-aws/SearchTools

feature: Add AbstractRetriverTool, VectorDBTool, NeuralSparseTools
(cherry picked from commit c088f77)

* fix commons-lang3 version (#45) (#59)

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
Co-authored-by: zane-neo <[email protected]>
yuye-aws pushed a commit to yuye-aws/skills that referenced this pull request Apr 26, 2024
…lSparseTools (opensearch-project#58)

* Merge pull request opensearch-project#40 from zhichao-aws/SearchTools

feature: Add AbstractRetriverTool, VectorDBTool, NeuralSparseTools
(cherry picked from commit c088f77)

* fix commons-lang3 version (opensearch-project#45) (opensearch-project#59)

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
Co-authored-by: zane-neo <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants