-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log pattern tool improvement #474
Open
songkant-aws
wants to merge
10
commits into
opensearch-project:main
Choose a base branch
from
songkant-aws:log-pattern-tool-improvement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Log pattern tool improvement #474
songkant-aws
wants to merge
10
commits into
opensearch-project:main
from
songkant-aws:log-pattern-tool-improvement
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Songkan Tang <[email protected]>
Signed-off-by: Songkan Tang <[email protected]>
songkant-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
January 2, 2025 07:43
3 tasks
gaobinlong
reviewed
Jan 2, 2025
xluo-aws
reviewed
Jan 2, 2025
xluo-aws
reviewed
Jan 2, 2025
xluo-aws
reviewed
Jan 2, 2025
lyx-aws
reviewed
Jan 3, 2025
src/main/java/org/opensearch/agent/tools/utils/BrainLogParser.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Songkan Tang <[email protected]>
xluo-aws
reviewed
Jan 3, 2025
xluo-aws
reviewed
Jan 3, 2025
xluo-aws
reviewed
Jan 3, 2025
src/main/java/org/opensearch/agent/tools/utils/BrainLogParser.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Songkan Tang <[email protected]>
xluo-aws
reviewed
Jan 3, 2025
src/main/java/org/opensearch/agent/tools/utils/BrainLogParser.java
Outdated
Show resolved
Hide resolved
xluo-aws
approved these changes
Jan 5, 2025
lyx-aws
approved these changes
Jan 6, 2025
Signed-off-by: Songkan Tang <[email protected]>
Signed-off-by: Songkan Tang <[email protected]>
xinyual
reviewed
Jan 10, 2025
Signed-off-by: Songkan Tang <[email protected]>
Hailong-am
reviewed
Jan 13, 2025
src/main/java/org/opensearch/agent/tools/utils/BrainLogParser.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Songkan Tang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
============================================
+ Coverage 81.78% 82.11% +0.32%
- Complexity 193 333 +140
============================================
Files 11 16 +5
Lines 961 1571 +610
Branches 137 221 +84
============================================
+ Hits 786 1290 +504
- Misses 121 194 +73
- Partials 54 87 +33 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve log pattern tool with cutting edge log pattern parser by introducing Brain algorithm mentioned in this RFC: opensearch-project/OpenSearch#16627
Related Issues
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.