[Backport 2.x]Fix github ci linux build and RAG tool missing return (#477) #480
+37
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject#477) * fix github ci linux build Signed-off-by: Hailong Cui <[email protected]> * add missing dependencies Signed-off-by: Hailong Cui <[email protected]> * spotless Signed-off-by: Hailong Cui <[email protected]> * add logs for debug Signed-off-by: Hailong Cui <[email protected]> * update security test ci Signed-off-by: Hailong Cui <[email protected]> * fix missing return for RAGTool Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit f66c53b)
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
|
waiting for 2.19 version bump been merged |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #480 +/- ##
============================================
+ Coverage 81.63% 81.98% +0.34%
- Complexity 221 279 +58
============================================
Files 13 15 +2
Lines 1122 1404 +282
Branches 161 201 +40
============================================
+ Hits 916 1151 +235
- Misses 144 174 +30
- Partials 62 79 +17 ☔ View full report in Codecov by Sentry. |
Hailong-am
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90 and
zhichao-aws
as code owners
zhichao-aws
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick f66c53b from #477