Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tools to ToolPlugin #81

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

mingshl
Copy link
Contributor

@mingshl mingshl commented Dec 29, 2023

Description

Add tools to ToolPlugin

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mingshi Liu <[email protected]>
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (edf3150) 82.31% compared to head (5d7b962) 81.29%.

Files Patch % Lines
src/main/java/org/opensearch/agent/ToolPlugin.java 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #81      +/-   ##
============================================
- Coverage     82.31%   81.29%   -1.03%     
  Complexity      152      152              
============================================
  Files            12       12              
  Lines           871      882      +11     
  Branches        115      115              
============================================
  Hits            717      717              
- Misses           95      106      +11     
  Partials         59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhichao-aws zhichao-aws merged commit 018cd03 into opensearch-project:main Dec 29, 2023
14 of 15 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 29, 2023
Signed-off-by: Mingshi Liu <[email protected]>
(cherry picked from commit 018cd03)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhichao-aws pushed a commit that referenced this pull request Dec 29, 2023
(cherry picked from commit 018cd03)

Signed-off-by: Mingshi Liu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws pushed a commit to yuye-aws/skills that referenced this pull request Apr 26, 2024
(cherry picked from commit 018cd03)

Signed-off-by: Mingshi Liu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: yuye-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants