Base class for Integ test; add integ test for NeuralSparseSearchTool #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
zhichao-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90 and
joshuali925
as code owners
Signed-off-by: zhichao-aws <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=========================================
Coverage 81.29% 81.29%
Complexity 152 152
=========================================
Files 12 12
Lines 882 882
Branches 115 115
=========================================
Hits 717 717
Misses 106 106
Partials 59 59 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zhichao-aws <[email protected]>
Hailong-am
approved these changes
Dec 29, 2023
|
ready for review |
|
@zhichao-aws Thanks for your effort. Since we are planning to use remote inference, can you add a function for registering connector? |
Signed-off-by: zhichao-aws <[email protected]>
Sure. |
zane-neo
approved these changes
Jan 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 2, 2024
…86) * add common components Signed-off-by: zhichao-aws <[email protected]> * add common components Signed-off-by: zhichao-aws <[email protected]> * add basic components Signed-off-by: zhichao-aws <[email protected]> * rebase main Signed-off-by: zhichao-aws <[email protected]> * add basic components for it, add it Signed-off-by: zhichao-aws <[email protected]> * rebase main Signed-off-by: zhichao-aws <[email protected]> * tidy Signed-off-by: zhichao-aws <[email protected]> * change neural sparse model to pretrained tokenizer Signed-off-by: zhichao-aws <[email protected]> * rm redundant line Signed-off-by: zhichao-aws <[email protected]> * add comments Signed-off-by: zhichao-aws <[email protected]> * tidy Signed-off-by: zhichao-aws <[email protected]> * add register connector Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit 34ae75f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhichao-aws
added a commit
that referenced
this pull request
Jan 2, 2024
…arseSearchTool (#91) * Base class for Integ test; add integ test for NeuralSparseSearchTool (#86) * add common components Signed-off-by: zhichao-aws <[email protected]> * add common components Signed-off-by: zhichao-aws <[email protected]> * add basic components Signed-off-by: zhichao-aws <[email protected]> * rebase main Signed-off-by: zhichao-aws <[email protected]> * add basic components for it, add it Signed-off-by: zhichao-aws <[email protected]> * rebase main Signed-off-by: zhichao-aws <[email protected]> * tidy Signed-off-by: zhichao-aws <[email protected]> * change neural sparse model to pretrained tokenizer Signed-off-by: zhichao-aws <[email protected]> * rm redundant line Signed-off-by: zhichao-aws <[email protected]> * add comments Signed-off-by: zhichao-aws <[email protected]> * tidy Signed-off-by: zhichao-aws <[email protected]> * add register connector Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit 34ae75f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix http dependency Signed-off-by: zhichao-aws <[email protected]> * tidy Signed-off-by: zhichao-aws <[email protected]> * fix read http entity twice Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zhichao-aws <[email protected]>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
…arseSearchTool (opensearch-project#91) * Base class for Integ test; add integ test for NeuralSparseSearchTool (opensearch-project#86) * add common components Signed-off-by: zhichao-aws <[email protected]> * add common components Signed-off-by: zhichao-aws <[email protected]> * add basic components Signed-off-by: zhichao-aws <[email protected]> * rebase main Signed-off-by: zhichao-aws <[email protected]> * add basic components for it, add it Signed-off-by: zhichao-aws <[email protected]> * rebase main Signed-off-by: zhichao-aws <[email protected]> * tidy Signed-off-by: zhichao-aws <[email protected]> * change neural sparse model to pretrained tokenizer Signed-off-by: zhichao-aws <[email protected]> * rm redundant line Signed-off-by: zhichao-aws <[email protected]> * add comments Signed-off-by: zhichao-aws <[email protected]> * tidy Signed-off-by: zhichao-aws <[email protected]> * add register connector Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit 34ae75f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix http dependency Signed-off-by: zhichao-aws <[email protected]> * tidy Signed-off-by: zhichao-aws <[email protected]> * fix read http entity twice Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zhichao-aws <[email protected]> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Base class for Integ test; add integ test for NeuralSparseSearchTool
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.