Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy zip to output folder #89

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Dec 30, 2023

Description

This PR fixed the issue that plugin zip is not copied to artifacts folder, the consequence was opensearch-build will not include skills when assembling opensearch distribution.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yulong Ruan <[email protected]>
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (051b79a) 81.29% compared to head (00a7a20) 81.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #89   +/-   ##
=========================================
  Coverage     81.29%   81.29%           
  Complexity      152      152           
=========================================
  Files            12       12           
  Lines           882      882           
  Branches        115      115           
=========================================
  Hits            717      717           
  Misses          106      106           
  Partials         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhichao-aws zhichao-aws merged commit 4573cc3 into opensearch-project:main Jan 4, 2024
15 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 4, 2024
(cherry picked from commit 4573cc3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zane-neo pushed a commit that referenced this pull request Jan 4, 2024
(cherry picked from commit 4573cc3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws pushed a commit to yuye-aws/skills that referenced this pull request Apr 26, 2024
…#105)

(cherry picked from commit 4573cc3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: yuye-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants