Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Issue Tracking Document and Issue Template #61

Merged
merged 3 commits into from
Jul 1, 2017

Conversation

hai1337
Copy link
Contributor

@hai1337 hai1337 commented Jun 29, 2017

issue_tracking.md details both the triage and developer flows when it comes to tracking and resolving issues.

The ISSUE_TEMPLATE.md in this PR is related to this repo. There will be a similar one for osc.org with an additional section for the website. The code repo issue templates will be similar to normal defect info: expected behavior, actual behavior, steps to reproduce with the additional Status section.

Notice the labels added in each repository. The document repos contain slightly different labels, e.g., document repos will not have defect/product-code labels.

This issue addresses part of #51 by creating the template.

@hai1337
Copy link
Contributor Author

hai1337 commented Jun 30, 2017

@opensecuritycontroller/osc_triage test notification


## Opening an Issue

Once a defect is found or you would like to suggest an improvement or start a discussion, the first step is to look at existing issues to see if it is already being tracked. If the issue is not being tracked, create a new one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we point out to existing issues mark down doc or page ?. or like knowledge base.

Copy link
Contributor Author

@hai1337 hai1337 Jun 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be really hard to keep up to date since every issue will have to be updated on the document. The issue section on github will be the most accurate and allows to filter by labels which should help narrow it down.

* triage/re-evaluate

Assigned Priority
* priority/high
Copy link
Contributor

@karimull karimull Jun 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have low, medium, high, and critical. ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can others confirm we want a fourth priority?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking other projects/tech articles. We can add fourth priority as well.

Choose only **one** of the following label types:
* defect
* discussion
* improvement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we label documentation bugs.. can we add one more label for that?.

Copy link
Contributor Author

@hai1337 hai1337 Jun 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three label types are the three main namespaces. If you look at the actual labels on the osc-core repository (go to issues -> labels), it shows defect/documentation, defect/product-code, and defect/unit-test. The reason why this is shown with just the namespace is that not every individual label applies to all repositories, for example, defect/product-code does not apply to the community repo. I kept it minimal to just the namespaces to avoid confusion on specific labels being used in specific repos.

Also, thanks for the review!!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good point though, I will try to make it more clear that they are the base of each label.

@hai1337
Copy link
Contributor Author

hai1337 commented Jun 30, 2017

Also, for reference, the following will be the issue_template.md for code repositories:

Expected Behavior

Actual Behavior

Steps to Reproduce

Additional Information (Optional)

Status

  • Reproduced
  • In Progress
  • Pull Request Out
  • Validated

karimull
karimull previously approved these changes Jun 30, 2017
Copy link
Contributor

@karimull karimull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let see what other have to say about 4(low,medium,high,critical) issues priorities...

Copy link
Contributor

@larkinscarvalho larkinscarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Karim did a great job finding issues. :)

@hai1337 hai1337 changed the title Adding issue tracking document Adding Issue Tracking Document and Issue Template Jun 30, 2017
emanoelxavier
emanoelxavier previously approved these changes Jun 30, 2017

**Document Location**: [PATH_TO_DOCUMENT](FULL_LINK)

[//]: # (DELETE THIS LINE: If the document exists, replace PATH_TO_DOCUMENT with the path to the document header for example, path/name.md#header and replace FULL_LINK with full link of the path to the document header. If you are proposing a new document, replace PATH_TO_DOCUMENT with the path to the document header of where it should go.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace the current example with a link to a real document header within Community? Replace path/name.md... with a real one.

@emanoelxavier emanoelxavier merged commit 3183b1e into opensecuritycontroller:master Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants