Skip to content

Add Basic Dockerfile #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add Basic Dockerfile #294

wants to merge 3 commits into from

Conversation

twa16
Copy link

@twa16 twa16 commented May 19, 2025

Summary:
This PR adds a minimal multi-stage Dockerfile to provide a consistent containerized environment for building and testing the project. It helps streamline local development, CI integration, and onboarding by encapsulating dependencies. It is also helpful for running the software locally quickly.

Documentation:
I think it would be helpful to add documentation on how to run this quickly. I am just not sure if you all would want that in the README, the Developer Guide, or in a separate markdown file. Happy to add that if you all point me in the right direction.

@earocorn
Copy link

This is great, but the default OSGi bundle repo in dist/osgi/config.json is quite outdated, and developers often use the osh-node-dev-template project for testing core, addon, and build changes together. Would you be able to create a similar Dockerfile for osh-addons, and a docker-compose.yml for osh-node-dev-template? Then we could test containerized environments of the individual repos (osh-addons & osh-core), as well as the two working together.

It would be great to have an easy way to set up both an OSGi bundle repository server (with osh-addons) and OSH server (osh-core), with the local bundle server linked to the local OSH node.

We can also work on adding this documentation for containerized deployments/testing in the osh-docs repository.

@twa16
Copy link
Author

twa16 commented Jun 13, 2025

Ok! That works!

I am thinking we keep this open until I wrap that up and we can add a little blurb to the readme that leads to that Dockerfile in the other repo?

@twa16 twa16 marked this pull request as draft June 13, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants