You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Right now we run all checks in a series, but there could some scenarios where a number of checks preclude each other.
Ex 1: in the osm-health connectivity pod-to-pod command, if we were to add a check for permissive traffic policy mode, any SMI traffic target checks would not be run.
Ex 2: in the same command - if the pods are referenced by a traffic target, could do an additional check to output whether the protocol is tcp or httproute. (that being said, this particular example could be achieved by including the protocol type in the diagnostic info of the check)
I think there are enough cases where adding this additional logic would be beneficial. This would require updating checks to have a distinct output that could be used to preclude other checks being run. Would require some changes to the runner and probably a GetOutcomeType() method added to the outcomes created in #70
The text was updated successfully, but these errors were encountered:
Right now we run all checks in a series, but there could some scenarios where a number of checks preclude each other.
Ex 1: in the
osm-health connectivity pod-to-pod
command, if we were to add a check for permissive traffic policy mode, any SMI traffic target checks would not be run.Ex 2: in the same command - if the pods are referenced by a traffic target, could do an additional check to output whether the protocol is tcp or httproute. (that being said, this particular example could be achieved by including the protocol type in the diagnostic info of the check)
I think there are enough cases where adding this additional logic would be beneficial. This would require updating checks to have a distinct output that could be used to preclude other checks being run. Would require some changes to the runner and probably a GetOutcomeType() method added to the outcomes created in #70
The text was updated successfully, but these errors were encountered: