This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Prototype for Chainable Commands #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalier
force-pushed
the
chainableOutcome
branch
2 times, most recently
from
e9f5796 to
b8dbe86
Compare
Signed-off-by: Shalier Xia <[email protected]>
shalier
force-pushed
the
chainableOutcome
branch
from
b8dbe86 to
1f1cb4f
Compare
|
need to figure out a good way to represent the graph of dependencies |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow us to create checks that are dependent on the result of another check
and resolves issue #73
All checks would be added to the
DependencyChecksmap with a mapped value offalseand upon the check passing the mapped value would be set totrueThe Skip code in
pkg/kubernetes/namespace/injected.gois an example to see how to make commands chainable. It will be removed after review.