Skip to content

Conversation

@zhfeng
Copy link

@zhfeng zhfeng commented Oct 24, 2025

  • Check some tools before we start working
  • Keep the codebase up-to-date and always create new fix branch against the upstream main

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.

- Check some tools before we start working
- Keep the codebase up-to-date and always create new fix branch against the upstream main
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 24, 2025
@openshift-ci-robot
Copy link

@zhfeng: This pull request explicitly references no jira issue.

In response to this:

  • Check some tools before we start working
  • Keep the codebase up-to-date and always create new fix branch against the upstream main

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dgoodwin and enxebre October 24, 2025 11:12
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhfeng
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Check if current directory is a valid git repository
- Ensure working directory is clean or warn user about uncommitted changes
- Validate upstream remote is properly configured
- Fetch latest changes from upstream repository: `git fetch upstream`
Copy link
Contributor

@enxebre enxebre Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this assumes there's a remote that's named upstream. That conflicts with

- Always create the PR against the remote origin
which assumes is named origin.
May be the remote to create the PR against should be a new argument $2 that defaults to origin. If you agree, please make sure to add the argument-hints section in the metadata

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think so. It intends to keep the code up-to-date before starting to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants