Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve assembly-urls #4261

Merged
merged 1 commit into from
Oct 11, 2024
Merged

improve assembly-urls #4261

merged 1 commit into from
Oct 11, 2024

Conversation

joepvd
Copy link
Contributor

@joepvd joepvd commented Sep 27, 2024

  • understand advisories!
  • understand ecs
  • install for future

@joepvd
improve assembly-urls
08de8c4 
- understand advisories!
- understand ecs
- install for future
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

@joepvd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 08de8c4 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lgarciaaco
Copy link

/approve

@lgarciaaco
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
@joepvd joepvd added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: lgarciaaco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joepvd joepvd merged commit a25a9c9 into openshift-eng:master Oct 11, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lgarciaaco lgarciaaco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joepvd @lgarciaaco