Enhance get_advisories to Handle Empty Advisories and Basis Version Overrides #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinPl0
force-pushed
the
releases-fix
branch
from
a5c0b9e
to
d1c0ca7
Compare
MartinPl0
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
MartinPl0
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ashwindasr
requested changes
Jan 26, 2024
lib/http_requests.py
Outdated
| @@ -157,21 +157,33 @@ def get_advisories(branch_name): | |||
| if not current_advisories: | |||
| current_advisories = {} | |||
|
|
|||
| override_applied = False | |||
MartinPl0
force-pushed
the
releases-fix
branch
from
d1c0ca7
to
fa7268f
Compare
…verrides This commit updates the get_advisories function in http_requests.py. Changes include: - Filtering out releases with empty advisories. - Checking for 'advisories!' overrides not just in the current version, but also in each basis version while processing. This ensures that any empty or specific advisories from the basis versions are appropriately applied to the current version.
MartinPl0
force-pushed
the
releases-fix
branch
from
fa7268f
to
6abee7b
Compare
ashwindasr
approved these changes
Jan 31, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashwindasr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 4acb828
into
openshift-eng:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the get_advisories function in http_requests.py. Changes include: