ART-10882: Get RHCOS to build on new host #1110
Conversation
joepvd
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@joepvd: This pull request references ART-10882 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold |
joepvd
force-pushed
the
rhcos-new-host
branch
from
3542e75
to
2984be1
Compare
joepvd
force-pushed
the
rhcos-new-host
branch
from
2984be1
to
35bde0a
Compare
|
@joepvd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -47,6 +45,9 @@ def __init__(self, runtime: Runtime, new_build: bool, ignore_running: bool, vers | |||
| self.api_token = None | |||
| self._stream = None # rhcos stream the version maps to | |||
| self.dry_run = self.runtime.dry_run | |||
| self.jenkins_base_url = "https://jenkins-rhcos--prod-pipeline.apps.int.prod-stable-spoke1-dc-iad2.itup.redhat.com" | |||
| if self.version in ["4.15", "4.16", "4.17", "4.18", "4.19"]: | |||
There was a problem hiding this comment.
suggest using version compare
| @@ -47,6 +45,9 @@ def __init__(self, runtime: Runtime, new_build: bool, ignore_running: bool, vers | |||
| self.api_token = None | |||
| self._stream = None # rhcos stream the version maps to | |||
| self.dry_run = self.runtime.dry_run | |||
| self.jenkins_base_url = "https://jenkins-rhcos--prod-pipeline.apps.int.prod-stable-spoke1-dc-iad2.itup.redhat.com" | |||
There was a problem hiding this comment.
suggest putting this URL in the constants
There was a problem hiding this comment.
It used to be a module constant, which is appropriate, as this is the only place that consumes it.
I intend to restore that next week once we get the go ahead to produce all builds on the new instance.
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joepvd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit eecf97d
into
openshift-eng:main
No description provided.