Fix env var propagation with telemetry enabled #1123
Conversation
vfreex
force-pushed
the
fix-env-vars-for-trace-context
branch
from
c1419c2
to
71a923e
Compare
When OpenTelemetry is enabled, environment variables `TRACEPARENT` needs
to be set for child process for trace context propagation.
There is a bug in `cmd_gather_async`: If parameter `env` is not set or
set to `None`, all environment variables of the current process will be
passed to the child process. However, when injecting `TRACEPARENT`, we
pass `{'TRACEPARENT': 'something'}` into child process without other
environment variables of the current process, causing misbehavior in the
child process.
This PR will fix this by copying all environment variables of the
current process if `env` is not set.
vfreex
force-pushed
the
fix-env-vars-for-trace-context
branch
from
71a923e
to
ef5acde
Compare
|
@vfreex: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lgarciaaco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 2946ab9
into
openshift-eng:main
When OpenTelemetry is enabled, environment variables
TRACEPARENTneeds to be set for child process for trace context propagation.There is a bug in
cmd_gather_async: If parameterenvis not set or set toNone, all environment variables of the current process will be passed to the child process. However, when injectingTRACEPARENT, we pass{'TRACEPARENT': 'something'}into child process without other environment variables of the current process, causing misbehavior in the child process.This PR will fix this by copying all environment variables of the current process if
envis not set.