-
Notifications
You must be signed in to change notification settings - Fork 28
[ART-6668] don't sweep microshift bug without check #573
Conversation
Build #1
|
Build #2
|
Build #3
|
Build #4
|
Build #5
|
Build #6
|
# microshift is special since it has a separate advisory, and it's build is attached | ||
# after payload is promoted. So do not pre-emptively complain | ||
exception_packages.append('microshift') | ||
packages.append(constants.GOLANG_BUILDER_CVE_COMPONENT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is exception_packages
removed? I think it is better to keep it and make our logs clear about it is an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr updated, keep golang bug in exception
not_found_with_component = [(b.id, b.whiteboard_component) for b in not_found] | ||
not_found_with_component = [] | ||
for b in not_found: | ||
if b.whiteboard_component == "microshift" and len(errata.get_advisory_nvrs(advisory_id_map.get("microshift"))) == 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate Errata API call for the same advisory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr updated, move this check to bug checking loop
Build #7
|
LGTM |
for microshfit bug, don't attach and don't raise error if microshift advisory has no build
this change won't sweep microshift bugs by default so need to find bugs for microshift advisory after build attached, which included in https://issues.redhat.com/browse/ART-6669 with openshift-eng/aos-cd-jobs#3781