ART-7268 Say in bug that it will not be visible in advisory if so

[locriandev]

Ref. https://issues.redhat.com/browse/ART-7268

• rename runtime.bug_trackers into runtime.get_bug_tracker; the function returns a single object, and it's not a property so making this clear in the name. Also added return type hint: 3a43d55
• when moving MODIFIED bugs to QE, if the bug visibility is by any means restricted, add a comment stating that the bug won't be visible in the advisory: 9f83213

[joepvd]

lgtm, apart from test failure :)

[openshift-bot]

Build #2

.pkg: _optional_hooks> python /home/art/.local/lib/python3.8/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: get_requires_for_build_sdist> python /home/art/.local/lib/python3.8/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: freeze> python -m pip freeze --all
.pkg: pip==23.2.1,setuptools==68.0.0,wheel==0.41.0
.pkg: build_sdist> python /home/art/.local/lib/python3.8/site-packages/pyproject_api/_backend.py True setuptools.build_meta
py38: recreate env because dependencies removed: errata-tool@ git+https://github.com/red-hat-storage/[email protected]
py38: remove tox env folder /mnt/workspace/jenkins/working/art-tools_elliott_PR-581/.tox/py38
py38: install_deps> python -I -m pip install '.[tests]'
py38: install_package_deps> python -I -m pip install 'aiohttp[speedups]>=3.6' 'click>=8.1.3' 'errata-tool~=1.31.0' future 'jira>=3.4.1' 'koji>=1.18' 'pydantic~=1.10.7' pygit2==1.10.1 'python-bugzilla>=3.2' pyyaml requests 'requests-gssapi~=1.2.3' ruamel.yaml semver tenacity
py38: install_package> python -I -m pip install --force-reinstall --no-deps /mnt/workspace/jenkins/working/art-tools_elliott_PR-581/.tox/.tmp/package/3/rh-elliott-0.0.0.tar.gz
py38: commands[0]> coverage run --branch --source elliottlib -m unittest discover -t . -s tests/
..............................................Cannot find any corresponding flaw bugs for these trackers: [13]. These trackers do not have a valid whiteboard component value: [12].
..BZ 9 is ignored because its status was MODIFIED at the moment of sweep cutoff (2021-06-30 12:30:00), however its status changed back to ['ASSIGNED'] afterwards
..................................................................................................................................................
----------------------------------------------------------------------
Ran 194 tests in 1.240s

OK
To fix missing builds in other advisories:
elliott move-builds -k image --from 42 --to <target_advisory> --only operand-nvr-1-0
py38: commands[1]> coverage report
Name                                              Stmts   Miss Branch BrPart  Cover
-----------------------------------------------------------------------------------
elliottlib/__init__.py                               12      7      2      1    43%
elliottlib/assembly.py                              131     39     76      7    67%
elliottlib/assertion.py                              11      0      6      0   100%
elliottlib/brew.py                                  336    195    134      5    36%
elliottlib/build_finder.py                          114     12     74     15    86%
elliottlib/bzutil.py                                867    354    346     28    55%
elliottlib/cincinnati.py                             21     21      4      0     0%
elliottlib/cli/__init__.py                            0      0      0      0   100%
elliottlib/cli/__main__.py                          278    278     75      0     0%
elliottlib/cli/add_metadata_cli.py                   28     28      4      0     0%
elliottlib/cli/advisory_commons_cli.py               90     90     38      0     0%
elliottlib/cli/advisory_drop_cli.py                  39     39     14      0     0%
elliottlib/cli/advisory_images_cli.py                14     14      2      0     0%
elliottlib/cli/advisory_impetus_cli.py               22     22      6      0     0%
elliottlib/cli/attach_bugs_cli.py                    37     37     18      0     0%
elliottlib/cli/attach_cve_flaws_cli.py              130     65     60      9    46%
elliottlib/cli/change_state_cli.py                   44     44     16      0     0%
elliottlib/cli/cli_opts.py                           15      0     17      0   100%
elliottlib/cli/common.py                             48     12      6      1    69%
elliottlib/cli/create_cli.py                         70     70     20      0     0%
elliottlib/cli/create_placeholder_cli.py             36     36     12      0     0%
elliottlib/cli/create_textonly_cli.py                51     51      8      0     0%
elliottlib/cli/find_bugs_blocker_cli.py              43      4     10      3    87%
elliottlib/cli/find_bugs_kernel_cli.py              220     22     87     22    85%
elliottlib/cli/find_bugs_kernel_clones_cli.py       177     30     85     22    79%
elliottlib/cli/find_bugs_qe_cli.py                   44     12     14      1    67%
elliottlib/cli/find_bugs_sweep_cli.py               229     35    130     22    82%
elliottlib/cli/find_builds_cli.py                   269    200    179      2    19%
elliottlib/cli/find_unconsumed_rpms.py               98     98     56      0     0%
elliottlib/cli/get_golang_versions_cli.py            59     14     32      9    73%
elliottlib/cli/list_cli.py                           14     14      2      0     0%
elliottlib/cli/move_builds_cli.py                    44     44     16      0     0%
elliottlib/cli/puddle_advisories_cli.py              34     34      8      0     0%
elliottlib/cli/remove_bugs_cli.py                    45      6     14      6    80%
elliottlib/cli/repair_bugs_cli.py                    61      5     26      6    87%
elliottlib/cli/rhcos_cli.py                          93     93     52      0     0%
elliottlib/cli/rpmdiff_cli.py                       102    102     34      0     0%
elliottlib/cli/tag_builds_cli.py                    128    128     62      0     0%
elliottlib/cli/tarball_sources_cli.py                83     83     26      0     0%
elliottlib/cli/validate_rhsa.py                      45     45     16      0     0%
elliottlib/cli/verify_attached_bugs_cli.py          266     95    173     20    57%
elliottlib/cli/verify_attached_operators_cli.py     159     56     80      5    59%
elliottlib/cli/verify_cvp_cli.py                    166    166     78      0     0%
elliottlib/config_model.py                           22      0      0      0   100%
elliottlib/constants.py                              52      0      0      0   100%
elliottlib/cvp.py                                   216    216    113      0     0%
elliottlib/dotconfig.py                              54     11     30      6    75%
elliottlib/errata.py                                344    221    150      4    32%
elliottlib/errata_async.py                          160     19     60      8    87%
elliottlib/exceptions.py                             12      0      0      0   100%
elliottlib/exectools.py                              84      7     24      3    89%
elliottlib/gitdata.py                               171    137     76      0    14%
elliottlib/imagecfg.py                               21      2      0      0    90%
elliottlib/logutil.py                                 9      1      2      1    82%
elliottlib/metadata.py                              154     43     76     18    67%
elliottlib/model.py                                 105     22     30      2    79%
elliottlib/openshiftclient.py                        34     34      8      0     0%
elliottlib/pushd.py                                  21      0      2      0   100%
elliottlib/resultsdb.py                              28     28      4      0     0%
elliottlib/rhcos.py                                  80     80     16      0     0%
elliottlib/rpm_utils.py                              30     14     16      5    46%
elliottlib/rpmcfg.py                                  5      2      0      0    60%
elliottlib/rpmdiff.py                                31      0      0      0   100%
elliottlib/runtime.py                               280    203    106      2    22%
elliottlib/tarball_sources.py                        90     61     34      0    30%
elliottlib/util.py                                  297    139    110     15    50%
-----------------------------------------------------------------------------------
TOTAL                                              7073   3940   2975    248    41%
py38: commands[2]> flake8
.pkg: _exit> python /home/art/.local/lib/python3.8/site-packages/pyproject_api/_backend.py True setuptools.build_meta
  py38: OK (33.72=setup[29.80]+cmd[2.28,0.98,0.66] seconds)
  congratulations :) (34.03 seconds)

[thegreyd]

There's a part in story which says This comment should happen exactly once per bug.
There are cases when a bug is moved back to modified/assigned, where we might repeat ourselves

[thegreyd]

I'm not too hung up on that part, since right now we do the same with other comments (post everytime we move to qe). So not a blocker imo

[locriandev]

I'm not too hung up on that part, since right now we do the same with other comments (post everytime we move to qe). So not a blocker imo

Agree, I thought we could afford repeating ourselves in these cases