This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Remove bugzilla search from sweep commands #584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegreyd
force-pushed
the
remove_bz_from_sweep
branch
from
7f43a0b
to
26bbedb
Compare
thegreyd
changed the title
locriandev
reviewed
Aug 3, 2023
|
The try-catch block was useful when there were multiple bug trackers being run - so an error from one wouldn't fail the whole command - we would print it out and then continue. Now that it's just one bug tracker, any exception should end the command in failure which is fine since nothing else is running in parallel.. I am fine keeping it as well since we put in place these abstractions to support multiple bug trackers at any time |
|
Not sure about the timing. I'd like to be convinced that for legacy releases that may see an update (3.11, 4.6, ...) we can find bugs. These are the potential problems: So I think we need to get these to jira, or wait until these are out. |
thegreyd
changed the title
thegreyd
added
the
do-not-merge
thegreyd
changed the title
|
Ack. Let's park this PR until we have confirmation |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normal OCP bugs are no longer allowed to open in Bugzilla.
Bugzilla is only used for tracking flaw bugs for OCP purposes (which are not part of sweep commands)
So remove searching bugzilla for ocp bugs
Test
./elliott --group openshift-4.13 --assembly 4.13.8 find-bugs:sweep --use-default-advisory microshift --noop