Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ART-6804: Switch to multi in ci #5618

Open
wants to merge 4 commits into
base: openshift-4.19
Choose a base branch
from

Conversation

joepvd
Copy link
Contributor

@joepvd joepvd commented Nov 4, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@ashwindasr
Copy link
Contributor

ashwindasr commented Nov 6, 2024

Once this PR is not draft, might wanna cherry pick to 4.19

@joepvd joepvd marked this pull request as ready for review November 8, 2024 09:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2024
@joepvd joepvd changed the base branch from openshift-4.18 to openshift-4.19 November 8, 2024 09:07
@joepvd
Copy link
Contributor Author

joepvd commented Nov 8, 2024

Fixing tests: openshift-eng/art-tools#1112

Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from joepvd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joepvd joepvd changed the title Switch to multi in ci ART-6804: Switch to multi in ci Nov 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2024

@joepvd: This pull request references ART-6804 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 8, 2024
upstream_image: registry.ci.openshift.org/ocp/builder:rhel-9-enterprise-base-multi-openshift-{MAJOR}.{MINOR}
upstream_image: registry.ci.openshift.org/ocp/{MAJOR}.{MINOR}:base-rhel9

okd_alignment:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we could produce an image based on https://quay.io/centos/centos:stream9 with our https://github.com/openshift-eng/ocp-build-data/blob/openshift-4.18/ci_images/dnf_wrapper.sh script installed on top of it.
For OKD, this base image can't be based on RHEL. It must be based on centos stream. This makes it impossible to build the desired image in OSBS.
okd_alignment only instructs the creation of PRs in openshift/release which build OKD variants of images when PR merge in upstream component repositories.

Generated with:
```sh
sed -i 's/member: openshift-base-rhel9/member: openshift-enterprise-base-rhel9/' $(
  git grep -l 'member: openshift-base-rhel9' | grep -v images/openshift-enterprise-base-rhel9.yml)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants