Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ai-lab chatbot helm chart OWNERS file #1669

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Nov 14, 2024

The PR is following the onboarding documentation for the openshift charts (here).

As a result this is the first of the two PRs adding only the OWNERS of the community/ai-lab/chatbot/ chart.

After this one is merged a second PR will add the tar file of the chart.

@thepetk thepetk changed the title Add ai-lab-chatbot OWNERS file Add ai-lab chatbot helm chart OWNERS file Nov 14, 2024
charts/community/ai-lab/chatbot/OWNERS Outdated Show resolved Hide resolved
charts/community/ai-lab/chatbot/OWNERS Outdated Show resolved Hide resolved
Signed-off-by: thepetk <[email protected]>
Copy link

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@thepetk thepetk marked this pull request as ready for review November 15, 2024 13:43
Copy link
Contributor

Submission Facts Mismatch

The content of the OWNERS file and your submission path do not seem to match. Double check that
your vendor label and chart name values in your OWNERS file match with your submission path.

This comment was auto-generated by GitHub Actions.

Copy link
Contributor

Thank you for submitting PR #1669 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[INFO] OWNERS file changes require manual review by maintainers.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "", "chart_name": ""}

Copy link
Contributor

🔓 Maintainers:

The OWNERS file contributed here has a chart name that is AVAILABLE!

The chart name 'chatbot-ai-sample' does not appear in our lockfile.

After reviewing this pull request, please re-run this workflow once more before merging.

This comment was auto-generated by GitHub Actions.

Copy link
Contributor

Thank you for submitting PR #1669 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[INFO] OWNERS file changes require manual review by maintainers.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "", "chart_name": ""}

@thepetk
Copy link
Contributor Author

thepetk commented Nov 15, 2024

[INFO] OWNERS file changes require manual review by maintainers.

Looking into older PRs I think the error is because the check is related with the chart addition.

Copy link
Contributor

🔓 Maintainers:

The OWNERS file contributed here has a chart name that is AVAILABLE!

The chart name 'chatbot-ai-sample' does not appear in our lockfile.

After reviewing this pull request, please re-run this workflow once more before merging.

This comment was auto-generated by GitHub Actions.

Copy link
Contributor

Thank you for submitting PR #1669 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[INFO] OWNERS file changes require manual review by maintainers.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "", "chart_name": ""}

Copy link
Collaborator

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@komish komish merged commit 8c1d01d into openshift-helm-charts:main Nov 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants