Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fail OWNERS PR from partners #387

Closed

Conversation

mgoerens
Copy link
Contributor

In case of an OWNERS PR submitted by a partner, the error message is different than in the case of a community/redhat OWNERS PR.

This copies the existing behavior that can be found here:

if "OWNERS" in none_chart_files:
file_path = none_chart_files["OWNERS"]
path_parts = file_path.split("/")
category = path_parts[1] # Second after charts
if category == "partners":
msg = "[ERROR] OWNERS file should never be set directly by partners. See certification docs."
print(msg)
gitutils.add_output("owners-error-message", msg)
elif (
matches_found > 0
): # There is a mix of chart and non-chart files including OWNERS
msg = "[ERROR] Send OWNERS file by itself in a separate PR."
print(msg)
gitutils.add_output("owners-error-message", msg)
elif len(files) == 1: # OWNERS file is the only file in PR
msg = "[INFO] OWNERS file changes require manual review by maintainers."
print(msg)
gitutils.add_output("owners-error-message", msg)

In case of an OWNERS PR submitted by a partner, the error message is
different than in the case of a community/redhat OWNERS PR.

Signed-off-by: Matthias Goerens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant