[DO NOT REVIEW] Switch to submission validate #391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
mgoerens
force-pushed
the
switch_to_submission_validate
branch
from
e5b9516
to
95829c6
Compare
This was referenced Sep 25, 2024
mgoerens
force-pushed
the
switch_to_submission_validate
branch
6 times, most recently
from
d368703
to
6e89a01
Compare
This PR refactors the certification pipeline by splitting the chart-verifier job into three jobs, running sequentially: - The new 'validate-submission' is responsible for extracting and validating all information related to a PR. - The existing 'chart-verifier' job is now only responsible for running chart-verifier against the Chart source (if provided, or verifies the submitted report.yaml instead). - The new 'manage-gh-pr' adds a comment on the PR, and merges it in case the pipeline was successfull. This PR also introduces a new mechanism for passing information between jobs. In addition to the existing GitHub outputs, a submission.json artifact containing a json representation of the Submission object is created in 'validate-submission'. Subsequent steps/jobs now have the possibility to read from this file. The main pursued goal behind this PR is to better separate concerns and avoid mixed up logic, thus improving readability and clarity of our pipeline and improve future maintainability and onboarding. This PR also opens up the ability to reducde code deduplication and redundant checks. In the interest of keeping this PR to a minimum, this has not been fully done here. One example: get-verify-params.py currently queries the GitHub API in order to get chart's information, while they are already available in the submission.json artifact. This rather trivial change is left for a future PR. Note that the 'submission' python module is essentially replacing the old 'checkpr' module. The only function remaining used by other modules being 'get_file_match_compiled_patterns', it is moved to the 'reporegex' module. Closes openshift-helm-charts#296 Signed-off-by: Matthias Goerens <[email protected]>
mgoerens
force-pushed
the
switch_to_submission_validate
branch
from
6e89a01
to
42852df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.