Skip to content

Commit

Permalink
Use GITHUB_TOKEN to approve PRs instead instead of the bot
Browse files Browse the repository at this point in the history
This has historically used a token provided by a maintainer. That token was revoked and the bot's token was used instead, but we run into issues approving PRs because the bot is also the submitter of the PR.

This works around that issue.
  • Loading branch information
komish committed Sep 13, 2023
1 parent 7ba5d66 commit 9acdc6f
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,11 @@ jobs:
if: ${{ steps.check_report.conclusion == 'success' }}
uses: hmarr/auto-approve-action@v2
with:
github-token: ${{ secrets.BOT_TOKEN }}
# Using the GitHub Token here is a temporary fix because the bot cannot
# approve their own PRs. Long-term solution will likely be to create a
# second BOT account to use here, or change the production workflows
# to use GITHUB_TOKEN for this task to match this repo.
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Merge PR
id: merge_pr
Expand Down

0 comments on commit 9acdc6f

Please sign in to comment.