Update SkipIfOnlyChanged pattern to not include hack/lib dirs #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matzew
reviewed
Aug 12, 2025
pkg/prowgen/prowgen_tests.go
Outdated
| @@ -38,7 +38,7 @@ const ( | |||
| // Phony targets in Makefile that should be skipped. | |||
| makefilePhonyTarget = ".PHONY" | |||
| // Files which do not require to run builds on Prow | |||
| prowSkipIfOnlyChangedFiles = "^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/.*|^OWNERS.*|.*\\.md" | |||
| prowSkipIfOnlyChangedFiles = "^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^OWNERS.*|.*\\.md" | |||
There was a problem hiding this comment.
perhaps we just exclude hack/lib folder?
There was a problem hiding this comment.
I hope the patter in cf3c282 works :D
creydr
force-pushed
the
update-skipifonlychanged-for-hack-dir
branch
from
1fddde2 to
cf3c282
Compare
creydr
changed the title
|
@matzew can you recheck? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring changes on the hack dir does not make sense always. For example in SO, we have some Kafka config in hack/lib folder. Therefor we update the pattern to exclude hack, but not hack/lib
Slack: https://redhat-internal.slack.com/archives/CD87JDUB0/p1755005331665209