Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoC: Add hosted integration testing #714

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

PoC: Add hosted integration testing #714

wants to merge 3 commits into from

Conversation

sebrandon1
Copy link
Collaborator

@sebrandon1 sebrandon1 commented Oct 4, 2024 •
edited
Loading

Automatically runs integration testing against both arm64 and x86 free tier Github Actions runners.

@sebrandon1 sebrandon1 force-pushed the integration_testing branch 9 times, most recently from ea8919a to 8f45b25 Compare October 4, 2024 20:55
@sebrandon1 sebrandon1 force-pushed the integration_testing branch 2 times, most recently from 3ed4b1c to 0f2f1d9 Compare October 22, 2024 18:15
@sebrandon1 sebrandon1 force-pushed the integration_testing branch 2 times, most recently from 468218d to 96cb7ff Compare November 1, 2024 15:43
@sebrandon1 sebrandon1 force-pushed the integration_testing branch 2 times, most recently from ab717c0 to 96ef6df Compare November 11, 2024 14:55
kononovn
kononovn requested changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check few comments.

@sebrandon1 sebrandon1 force-pushed the integration_testing branch 3 times, most recently from b513539 to 3ce876b Compare November 27, 2024 21:18
@sebrandon1 sebrandon1 force-pushed the integration_testing branch 2 times, most recently from f883968 to 613c004 Compare January 16, 2025 22:04
klaskosk
klaskosk previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@klaskosk klaskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

integration/integration.go Outdated Show resolved Hide resolved
@sebrandon1 sebrandon1 force-pushed the integration_testing branch 6 times, most recently from 9f84e47 to 7f4c3bc Compare January 23, 2025 16:28
@sebrandon1 sebrandon1 force-pushed the integration_testing branch 4 times, most recently from e306ee2 to d1cef74 Compare January 29, 2025 20:07
kononovn
kononovn requested changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix few comment's. It's almost ready.

@sebrandon1 sebrandon1 force-pushed the integration_testing branch 3 times, most recently from eafd53e to e879831 Compare February 5, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kononovn kononovn kononovn requested changes

@klaskosk klaskosk klaskosk left review comments

@trewest trewest Awaiting requested review from trewest trewest is a code owner

@achuzhoy achuzhoy Awaiting requested review from achuzhoy achuzhoy is a code owner

@cdvultur cdvultur Awaiting requested review from cdvultur cdvultur is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebrandon1 @kononovn @klaskosk