PoC: Add hosted integration testing #714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
requested review from
kononovn,
trewest,
achuzhoy,
cdvultur and
klaskosk
as code owners
sebrandon1
force-pushed
the
integration_testing
branch
9 times, most recently
from
ea8919a
to
8f45b25
Compare
sebrandon1
force-pushed
the
integration_testing
branch
2 times, most recently
from
3ed4b1c
to
0f2f1d9
Compare
sebrandon1
force-pushed
the
integration_testing
branch
2 times, most recently
from
468218d
to
96cb7ff
Compare
sebrandon1
force-pushed
the
integration_testing
branch
2 times, most recently
from
ab717c0
to
96ef6df
Compare
sebrandon1
force-pushed
the
integration_testing
branch
from
96ef6df
to
5ce88b4
Compare
kononovn
reviewed
Nov 26, 2024
| assert.Equal(t, "deployment object delete-test does not exist in namespace "+randomNamespace, err.Error()) | ||
| } | ||
|
|
||
| func TestDeploymentWithNodeSelector(t *testing.T) { |
There was a problem hiding this comment.
You can remove this test. We are going to cover only simple scenarios
kononovn
reviewed
Nov 26, 2024
| @@ -0,0 +1,547 @@ | |||
| //go:build integration | |||
There was a problem hiding this comment.
Please remove all test cases except.
Create/Delete/Pull and 1 With*
kononovn
reviewed
Nov 26, 2024
| @@ -0,0 +1,30 @@ | |||
| //go:build integration | |||
There was a problem hiding this comment.
Let's avoid using random values. I think we can run all test cases in eco-goinfra-intergation-tests namespace.
kononovn
reviewed
Nov 26, 2024
| @@ -0,0 +1,62 @@ | |||
| name: setup-partner-cluster | |||
There was a problem hiding this comment.
Let's remove "partner" from code.
kononovn
reviewed
Nov 26, 2024
| with: | ||
| go-version: 1.23.2 | ||
|
|
||
| - name: Setup partner cluster |
kononovn
requested changes
Nov 26, 2024
sebrandon1
force-pushed
the
integration_testing
branch
3 times, most recently
from
b513539
to
3ce876b
Compare
sebrandon1
force-pushed
the
integration_testing
branch
from
3ce876b
to
a9179e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress!