add-metallb-nodeselector-tc #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkopels
force-pushed
the
add-nodeselector-testcase
branch
4 times, most recently
from
064e163 to
c92959e
Compare
gkopels
force-pushed
the
add-nodeselector-testcase
branch
from
c92959e to
1019bfe
Compare
evgenLevin
reviewed
Jan 14, 2025
|
|
||
| // ValidateLocalPref verifies local pref from FRR is equal to configured Local Pref. | ||
| func ValidateLocalPref(frrPod *pod.Builder, localPref uint32, ipFamily string) error { | ||
| var ( |
| err error | ||
| ) | ||
|
|
||
| res, err = frrPod.ExecCommand(append(netparam.VtySh, |
There was a problem hiding this comment.
please use getBGPStatus func
| return fmt.Errorf("failed to parse route local preference %w", err) | ||
| } | ||
|
|
||
| for _, locPref := range toParse.Routes { |
There was a problem hiding this comment.
Suggested change
| for _, locPref := range toParse.Routes { | |
| for _, route := range toParse.Routes { |
| } | ||
|
|
||
| for _, locPref := range toParse.Routes { | ||
| if locPref[0].LocalPref != localPref { |
There was a problem hiding this comment.
do we expect to validate only first route?
| } | ||
| } | ||
|
|
||
| return err |
| Expect(err).ToNot(HaveOccurred(), "Fail to validate local preference") | ||
|
|
||
| By("Validate BGP Community exists with the node selector") | ||
| output, err := frr.GetBGPCommunityStatus(frrPod0, noAdvertise, strings.ToLower(netparam.IPV4Family)) |
There was a problem hiding this comment.
Suggested change
| output, err := frr.GetBGPCommunityStatus(frrPod0, noAdvertise, strings.ToLower(netparam.IPV4Family)) | |
| bgpStatus, err := frr.GetBGPCommunityStatus(frrPod0, noAdvertise, strings.ToLower(netparam.IPV4Family)) |
| Expect(len(output.Routes)).To(Equal(1)) | ||
|
|
||
| By("Validate BGP Community does not exist without the node selector") | ||
| output, err = frr.GetBGPCommunityStatus(frrPod1, customCommunity, strings.ToLower(netparam.IPV4Family)) |
There was a problem hiding this comment.
Suggested change
| output, err = frr.GetBGPCommunityStatus(frrPod1, customCommunity, strings.ToLower(netparam.IPV4Family)) | |
| bgpStatus, err = frr.GetBGPCommunityStatus(frrPod1, customCommunity, strings.ToLower(netparam.IPV4Family)) |
| _, err := metallb.NewBPGPeerBuilder(APIClient, name, NetConfig.MlbOperatorNamespace, | ||
| peerIP, tsparams.LocalBGPASN, tsparams.LocalBGPASN).WithPassword(tsparams.BGPPassword).Create() | ||
|
|
||
| return err |
| return ipAddressPool | ||
| } | ||
|
|
||
| func createBGPPeer(name, peerIP string) error { |
There was a problem hiding this comment.
why don't use createBGPPeerAndVerifyIfItsReady?
Comment on lines
+255
to
+256
| setupMetalLbService("service-1", netparam.IPV4Family, ipAddressPool1, "Cluster") | ||
| setupMetalLbService("service-2", netparam.IPV4Family, ipAddressPool2, "Cluster") |
There was a problem hiding this comment.
is that expected that you create 2 the same services with different name in case single IP addressPool?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving test cases from cnf-gotest to eco-gotest