lint,cnf ran: enable ginkgo linter for cnf/ran #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables the ginkgo linter from golangci-lint but restricts it to the cnf/ran subdirectory. Since this linter covers many conventions that have been mostly enforced through code review in cnf/ran it is useful to have it enabled. However, it can be fairly strict so it has been left to teams to opt-in to using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the ginkgo linter from golangci-lint but restricts it to the cnf/ran subdirectory. Since this linter covers many conventions that have been mostly enforced through code review in cnf/ran it is useful to have it enabled. However, it can be fairly strict so it has been left to teams to opt-in to using it.