sched: manifests: disable leader election by default #1079
Conversation
Defaults for leader election are questionable at best and likely harmful. So, we should default the leader election to off and enable it only if user sets so, because this will make us to tune all the leader election parameters and set sane values. Signed-off-by: Francesco Romani <[email protected]>
openshift-ci
bot
added
the
approved
ffromani
added
cherry-pick-candidate
|
/cherry-pick release-4.17 |
|
@ffromani: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
xref: 4ac0f7c |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override ci/prow/ci-e2e-install-hypershift |
|
@Tal-or: Overrode contexts on behalf of Tal-or: ci/prow/ci-e2e-install-hypershift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/ci-e2e-install-hypershift the lane is known broken AND we are actively working to fix it |
|
@ffromani: Overrode contexts on behalf of ffromani: ci/prow/ci-e2e-install-hypershift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ffromani: new pull request created: #1082 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Defaults for leader election are questionable at best and likely harmful. So, we should default the leader election to off and enable it only if user sets so, because this will make us to tune all the leader election parameters and set sane values.