sched: always set the leader election parameters

[ffromani]

Because of a overlook, we used to set the leader election
params only if replicas > 1 was requested. This left the key and default corner case of replicas=1 with
compiled in defaults, which are questionable at best and most likely harmful for our use case.

Make sure to always set sane parameters, obviously taking into account the user desires from the spec
(Replicas field).

Add more logs to make troubleshooting easier

[ffromani]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ffromani]

/hold

we need controller tests

[ffromani]

/hold cancel

tests added

[ffromani]

/override ci/prow/ci-e2e-install-hypershift

[openshift-ci]

@ffromani: Overrode contexts on behalf of ffromani: ci/prow/ci-e2e-install-hypershift

In response to this:

/override ci/prow/ci-e2e-install-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Tal-or]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Tal-or,ffromani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Tal-or]

The waiting period for MCP to catch up has become flaky recently.

I wonder if it's somehow related to one of our recent changes or there's something broken in OCP

[ffromani]

same thoughts here. I'll keep watching

[ffromani]

/retest-required

[openshift-ci]

New changes are detected. LGTM label has been removed.

[ffromani]

/override ci/prow/ci-e2e-install-hypershift

fixes still pending, this is expected

[openshift-ci]

@ffromani: Overrode contexts on behalf of ffromani: ci/prow/ci-e2e-install-hypershift

In response to this:

/override ci/prow/ci-e2e-install-hypershift

fixes still pending, this is expected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ffromani]

/hold

let's wait for #1071 to go in

[ffromani]

/hold cancel

#1071 merged

[openshift-cherrypick-robot]

@ffromani: #1080 failed to apply on top of branch "release-4.17":

Applying: sched: always set the leader election parameters
Using index info to reconstruct a base tree...
M	controllers/numaresourcesscheduler_controller.go
M	pkg/status/status.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/status/status.go
CONFLICT (content): Merge conflict in pkg/status/status.go
Auto-merging controllers/numaresourcesscheduler_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 sched: always set the leader election parameters

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.